Skip to content

Commit

Permalink
addressed PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
thehenrytsai committed Jul 1, 2024
1 parent e5124bc commit 58cb180
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 0 additions & 3 deletions src/web5-connect/sql-ttl-cache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ export class SqlTtlCache {
* Retrieves a cache entry if it is not expired and cleans up expired entries.
*/
public async get(key: string): Promise<object | undefined> {
// clean up expired entries but no need to await for it to finish
this.cleanUpExpiredEntries();

const result = await this.db
.selectFrom(SqlTtlCache.cacheTableName)
.select('key')
Expand Down
1 change: 1 addition & 0 deletions src/web5-connect/web5-connect-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export class Web5ConnectServer {
* Creates a new instance of the Web5 Connect Server.
* @param params.baseUrl The the base URL of the connect server including the port.
* This is given to the Identity Provider (wallet) to fetch the Web5 Connect Request object.
* @param params.sqlTtlCacheUrl The URL of the SQL database to use as the TTL cache.
*/
public static async create({ baseUrl, sqlTtlCacheUrl }: {
baseUrl: string;
Expand Down

0 comments on commit 58cb180

Please sign in to comment.