Added support for synchronized proof-of-work challenge nonce across nodes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehenrytsai
requested review from
michaelneale,
mistermoe,
frankhinek,
finn-block and
LiranCohen
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 92.16% 90.63% -1.53%
==========================================
Files 20 20
Lines 1722 1752 +30
Branches 214 211 -3
==========================================
+ Hits 1587 1588 +1
- Misses 135 164 +29 ☔ View full report in Codecov by Sentry. |
LiranCohen
previously approved these changes
Jan 22, 2024
There was a problem hiding this comment.
This is great! Really clever way of allowing a deterministic nonce and accounting for the time drift between instances.
My only nit/suggestion is I'm not sure if I saw a test that actually accounts for the nonce refresh + validation. I know there's a test that stubs out the nonce refresh and makes sure it's called.
Other than that it looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for synchronized proof-of-work challenge nonce across nodes by:
With this PR, the registration endpoint with proof-of-work is now ready to be used in a production environment with many nodes.