-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Web5 Connect Server #139
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 93.93% 94.38% +0.45%
==========================================
Files 25 26 +1
Lines 2374 2566 +192
Branches 316 330 +14
==========================================
+ Hits 2230 2422 +192
Misses 143 143
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! One step closer!!
Just some nits about using loglevel
since that's used in most places for logging.
Another thing I noticed, since fetching the request/response is stateful should we:
a) have google create sticky sessions for these requests?
b) use Redis as the cache mechanism?
Also, haven't looked too much into it since it's used sparsely on this repo, are you familiar with the request counter that exists? Do we want to count these requests/errors as well? I feel like logging should be enough tbh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸 🐐 🚀
- Ported web5 connect server into this repo. - Separated business logic from `express` into a `Web5ConnectServer` class. - Added tests for 100% new code coverage. - Added issue to track TODOs.
express
into aWeb5ConnectServer
class.