Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Web5 Connect Server #139

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Added Web5 Connect Server #139

merged 4 commits into from
Jun 28, 2024

Conversation

thehenrytsai
Copy link
Collaborator

  1. Ported web5 connect server into this repo.
  2. Separated business logic from express into a Web5ConnectServer class.
  3. Added tests for 100% new code coverage.
  4. Added issue to track TODOs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 99.49495% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.38%. Comparing base (22886cb) to head (4f3d005).

Files Patch % Lines
src/http-api.ts 98.95% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   93.93%   94.38%   +0.45%     
==========================================
  Files          25       26       +1     
  Lines        2374     2566     +192     
  Branches      316      330      +14     
==========================================
+ Hits         2230     2422     +192     
  Misses        143      143              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! One step closer!!

Just some nits about using loglevel since that's used in most places for logging.

Another thing I noticed, since fetching the request/response is stateful should we:
a) have google create sticky sessions for these requests?
b) use Redis as the cache mechanism?

Also, haven't looked too much into it since it's used sparsely on this repo, are you familiar with the request counter that exists? Do we want to count these requests/errors as well? I feel like logging should be enough tbh.

src/http-api.ts Outdated Show resolved Hide resolved
src/http-api.ts Outdated Show resolved Hide resolved
src/http-api.ts Outdated Show resolved Hide resolved
src/http-api.ts Outdated Show resolved Hide resolved
src/web5-connect/web5-connect-server.ts Outdated Show resolved Hide resolved
src/http-api.ts Show resolved Hide resolved
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 🐐 🚀

@thehenrytsai thehenrytsai merged commit 6471773 into main Jun 28, 2024
4 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/web5-connect branch June 28, 2024 20:45
bnonni pushed a commit to FormFree/dwn-server that referenced this pull request Aug 7, 2024
- Ported web5 connect server into this repo.
- Separated business logic from `express` into a `Web5ConnectServer`
class.
- Added tests for 100% new code coverage.
- Added issue to track TODOs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants