Addressed various initialization issues and patterns #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehenrytsai
requested review from
michaelneale,
mistermoe,
frankhinek,
finn-block and
LiranCohen
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
+ Coverage 94.77% 95.64% +0.86%
==========================================
Files 27 27
Lines 2756 2869 +113
Branches 353 374 +21
==========================================
+ Hits 2612 2744 +132
+ Misses 143 124 -19
Partials 1 1 ☔ View full report in Codecov by Sentry. |
LiranCohen
approved these changes
Jul 8, 2024
bnonni
pushed a commit
to FormFree/dwn-server
that referenced
this pull request
Aug 7, 2024
…dentity#143) There are more to be done, but this is a good start. - Fixed confusing patterns of existing async method take callbacks, and yet return immediately without invoking and awaiting on the callback. - Introduced `DwnServer.stop()` for clarity and consistency. - Introduced `HttpApi.close()` for clarity and consistency. - Added missing `removeProcessHandlers` as counterpart to `setProcessHandlers` for proper clean up. - Added `didResolver` to `DwnServerOptions` for overriding DID Resolver cache LevelDB implementation in tests to prevent DB locking issues. - Used Poller to make some tests more stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are more to be done, but this is a good start.
on the callback.
DwnServer.stop()for clarity and consistency.HttpApi.close()for clarity and consistency.removeProcessHandlersas counterpart tosetProcessHandlersfor proper clean up.didResolvertoDwnServerOptionsfor overriding DID Resolver cache LevelDB implementation in tests to prevent DB locking issues.