Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plugin support #145

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Added plugin support #145

merged 6 commits into from
Jul 11, 2024

Conversation

thehenrytsai
Copy link
Collaborator

  • Added plugin support for MessageStore, DataStore, ResumableDataStore, EventLog and EventStream.
  • Exposed config for EventStream.
  • Exposed config for ResumableTaskStore.
  • Refactored/consolidated repeated test code.
  • Various renames.

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 96.80000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.65%. Comparing base (24199fa) to head (d12c607).

Files Patch % Lines
src/storage.ts 96.51% 3 Missing ⚠️
src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   95.64%   95.65%   +0.01%     
==========================================
  Files          27       28       +1     
  Lines        2869     2922      +53     
  Branches      374      393      +19     
==========================================
+ Hits         2744     2795      +51     
- Misses        124      126       +2     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehenrytsai thehenrytsai marked this pull request as ready for review July 10, 2024 18:41
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🐐 🚀

This is such an elegant solution!

@thehenrytsai thehenrytsai merged commit 5ef7196 into main Jul 11, 2024
8 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/plugin branch July 11, 2024 17:50
bnonni pushed a commit to FormFree/dwn-server that referenced this pull request Aug 7, 2024
- Added plugin support for `MessageStore`, `DataStore`,
`ResumableDataStore`, `EventLog` and `EventStream`.
- Exposed config for `EventStream`.
- Exposed config for `ResumableTaskStore`.
- Refactored/consolidated repeated test code. 
- Various renames.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants