Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crypto import #161

Merged
merged 2 commits into from
Aug 16, 2024
Merged

fix crypto import #161

merged 2 commits into from
Aug 16, 2024

Conversation

shamilovtim
Copy link
Contributor

@shamilovtim shamilovtim commented Aug 15, 2024

i missed fixing this breaking change when i bumped web5 dids

  • added an assertion that would have caught the bug
  • added explicit dependency on web5/crypto because its there and was hidden

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.08%. Comparing base (1c6246f) to head (d018c6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   95.08%   95.08%           
=======================================
  Files          28       28           
  Lines        2951     2951           
  Branches      395      395           
=======================================
  Hits         2806     2806           
  Misses        144      144           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamilovtim shamilovtim merged commit c84699e into main Aug 16, 2024
8 checks passed
@shamilovtim shamilovtim deleted the tshamilov/crypto-tweak branch August 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants