Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter options to protocol path read route #166

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

csuwildcat
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.89%. Comparing base (1077722) to head (578e954).

Files with missing lines Patch % Lines
src/http-api.ts 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   95.08%   94.89%   -0.20%     
==========================================
  Files          28       28              
  Lines        2951     2956       +5     
  Branches      395      397       +2     
==========================================
- Hits         2806     2805       -1     
- Misses        144      150       +6     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can probably re-use the method from the other query. But won't block for it, we can revamp a lot of this API at a later time.

@LiranCohen LiranCohen merged commit c587adc into main Sep 11, 2024
8 checks passed
@LiranCohen LiranCohen deleted the add-protocol-read-filters branch September 11, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants