-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tombstones #31
Tombstones #31
Conversation
Although we’re planning to discuss the trade offs of this approach tomorrow, since we’ve got to get this bug fix in before any conclusion to that discussion, we should include a test that passes because a subsequent |
does this change anything around data retention - like is there a case where record could have been deleted on client and never made it to server but now does with a tombstone? that is my only feedback. |
Signed-off-by: Frank Hinek <[email protected]>
As discussed with @mistermoe and @thehenrytsai this afternoon:
Created Issue #32 to track. |
@michaelneale currently, anytime |
When a record is deleted via
RecordsDelete
, the initialRecordsWrite
is kept as a tombstone in additionto the
RecordsDelete
message. The data associated to that initialRecordsWrite
is deleted. If a record was writtenand deleted before it ever got to
dwn-server
, we end up in a situation where we still need to process the tombstoneso that we can process the
RecordsDelete
. This can and does happen when syncing.This PR introduces the ability to process
RecordsWrite
messages with no associated data.