Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding test coverage tracker #71

Merged

Conversation

flothjl
Copy link
Contributor

@flothjl flothjl commented Oct 3, 2023

Fixes #49

@codesandbox
Copy link

codesandbox bot commented Oct 3, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@flothjl flothjl marked this pull request as ready for review October 4, 2023 00:22
@flothjl flothjl requested a review from finn-block as a code owner October 4, 2023 00:22
@EbonyLouis EbonyLouis requested a review from diehuxx October 4, 2023 14:08
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Collaborator

@finn-block finn-block left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just need a few changes to the wording in contributing.md

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@flothjl flothjl requested a review from finn-block October 4, 2023 17:42
@finn-block
Copy link
Collaborator

sorry, I noticed the codecov action ref thing when i went to merge. Fix that and then we'll be good, I promise.

@flothjl
Copy link
Contributor Author

flothjl commented Oct 4, 2023

sorry, I noticed the codecov action ref thing when i went to merge. Fix that and then we'll be good, I promise.

No worries at all. Good catch.

@flothjl flothjl requested a review from finn-block October 4, 2023 19:06
@finn-block finn-block added the hacktoberfest-accepted Accepted PRs for the hacking month of October label Oct 4, 2023
@finn-block finn-block merged commit ac78e39 into decentralized-identity:main Oct 4, 2023
1 check passed
@flothjl flothjl deleted the flothjl/code-cov-tracker branch October 4, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted PRs for the hacking month of October
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code coverage tracker similar to either dwn-sdk-js or to web5-js
3 participants