Prettier for imports #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update .prettierrc.json
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
jerempy
force-pushed
the
prettier-for-imports
branch
from
43f5b72 to
6bc37dd
Compare
jerempy
commented
Oct 16, 2023
| @@ -182,7 +181,7 @@ export async function sendWsMessage( | |||
| socket.onopen = (_event): void => { | |||
| socket.onmessage = (event): void => { | |||
| socket.terminate(); | |||
| return resolve(<Buffer>event.data); | |||
| return resolve(event.data as Buffer); | |||
There was a problem hiding this comment.
linter was raising error as unclosed JSX. so casting it using as which does same thing
finn-block
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #57
I tried to get a close approximation from the earlier eslint rule. Not an exact, but pretty close.
The earlier rule was already removed here: 795d93b
I tried to match the descriptions in eslint: https://eslint.org/docs/latest/rules/sort-imports#examples
The import orders are done a littler differently with the prettier plugin. So i tried to get an idea of how most of the imports are being done and then wrote the import order to approximate that.
Then i ran prettier on code base - so there is a commit that shows what the import sorting will look like