Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sinon version backwards to what we use in dwn-sdk-js #79

Closed
wants to merge 1 commit into from

Conversation

diehuxx
Copy link
Collaborator

@diehuxx diehuxx commented Oct 18, 2023

In lieu of updating this lib to work with sinon 16, let's just pull it back to what we know works in dwn-sdk-js.

@diehuxx diehuxx requested a review from finn-block as a code owner October 18, 2023 21:08
@codesandbox
Copy link

codesandbox bot commented Oct 18, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov-commenter
Copy link

Codecov Report

Merging #79 (4e12192) into main (8818f30) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #79   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files          15       15           
  Lines         986      986           
  Branches      100      100           
=======================================
  Hits          793      793           
  Misses        193      193           

@diehuxx
Copy link
Collaborator Author

diehuxx commented Oct 18, 2023

#78 addressed this

@diehuxx diehuxx closed this Oct 18, 2023
@LiranCohen LiranCohen deleted the diehuxx/sinon-13 branch September 5, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants