Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move lint actions to their own job, add more checks, fix linting issues #85

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

finn-block
Copy link
Collaborator

  • an external contributor snuck some new dependencies in without updating package-lock.json, that sort of violation will now be caught in CI.
  • another external contributor helped us follow the GitHub markdown accessibility guidelines, but didn't add a CI action to ensure we keep up to date. This adds markdown linting, and most violations have been fixed
    • I decided to disable the line length rule. It's 2023 and screens are somewhat wider than 80 characters. Maybe in the future we'll turn it on with a higher limit

Copy link

codesandbox bot commented Oct 31, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov-commenter
Copy link

Codecov Report

Merging #85 (375e86b) into main (eee2559) will increase coverage by 2.27%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   80.62%   82.90%   +2.27%     
==========================================
  Files          15       15              
  Lines         986     1000      +14     
  Branches      100      140      +40     
==========================================
+ Hits          795      829      +34     
+ Misses        191      171      -20     

see 3 files with indirect coverage changes

* an external contributor snuck some new dependencies in without updating package-lock.json, this will now be caught
* another external contributor helped us follow the GitHub markdown accessibility guidelines (https://github.blog/2023-10-26-5-tips-for-making-your-github-profile-page-accessible/),
  but didn't add a CI action to ensure we keep up to date. Markdown linting is now added, and most violations have been fixed
  * I decided to disable the line length rule. It's 2023 and screens are somewhat wider than 80 characters. Maybe in the future we'll turn it on with a higher limit
@finn-block finn-block merged commit 3f5b3c5 into main Oct 31, 2023
6 checks passed
@LiranCohen LiranCohen deleted the misc-linting branch September 5, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants