Registration Gating (Proof-of-Work, Terms of Service) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
===========================================
+ Coverage 80.50% 91.24% +10.73%
===========================================
Files 15 20 +5
Lines 985 1702 +717
Branches 97 204 +107
===========================================
+ Hits 793 1553 +760
+ Misses 192 149 -43 ☔ View full report in Codecov by Sentry. |
finn-block
changed the title
…complete some tasks before they may user the server. proof of work challenge and terms of service challenges are currently available
finn-block
requested review from
michaelneale,
mistermoe,
frankhinek,
LiranCohen and
thehenrytsai
as code owners
* main: Removed the need for createProfile()
…ne scenario tests
* main: bump dwn-sql-store version and dwn-server (#98)
| clock.restore(); | ||
| }); | ||
|
|
||
| it('should facilitate tenant registration with terms-of-service and proof-or-work turned on', async () => { |
There was a problem hiding this comment.
@shamilovtim, this shows how tenant registration is done!
|
I've given it a first pass (minus the tests) and it looks good so far when analyzing the individual pieces. Want to spend a little more time today re-reviewing the PoW calculation pieces and giving it a last pass including tests. Just a few small nits and questions above. |
LiranCohen
reviewed
Jan 11, 2024
LiranCohen
requested changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds optional (disabled by default) authorization to all endpoints. New DIDs wishing to use an instance of dwn-server with registration requirements must complete a proof-of-work challenge, agree to the server's terms of service, or both. Requests for DIDs that have not completed the requirements will be rejected.
POW authorization can be enabled by setting
DWN_REGISTRATION_POW=true. Authorized DIDs are tracked in a database, configured by settingDWN_STORAGE_REGISTRATIONorDWN_STORAGE. Note that only SQL-based stores are supported.