Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker-compose.yaml #90

Merged

Conversation

andorsk
Copy link
Contributor

@andorsk andorsk commented Nov 13, 2023

added docker compose

added docker compose
@andorsk andorsk requested a review from finn-block as a code owner November 13, 2023 15:12
Copy link

codesandbox bot commented Nov 13, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@codecov-commenter
Copy link

Codecov Report

Merging #90 (cb3bb59) into main (44f2c93) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #90   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files          15       15           
  Lines        1000     1000           
  Branches      100      100           
=======================================
  Hits          809      809           
  Misses        191      191           

@finn-block
Copy link
Collaborator

What is the purpose of this? Is there some current need for a single-container compose file?

@andorsk
Copy link
Contributor Author

andorsk commented Nov 13, 2023

Yes. There are two reasons to provide this:

  1. As a reference to copy and paste into other docker composes. This is sometimes very useful and done in many repos outside this one. Even ssi-service provides a docker-compose that's helpful (albiet yes, more complicated). You can alternatively directly put this into the README. https://github.com/nicolaka/netshoot#netshoot-with-docker-compose is an example of one of many. I could find more if needed. It just makes life easier for devs and people that don't want to create the docker compose from scratch ( and may mess up in the process ).
  2. Because lots of people (including myself) primary use docker compose as a way to spin up services over invoking docker directly over the cmd line. Having an existing yaml ready is better. I rarely spin up docker container directly over the cli anymore, and I don't think I'm alone. I always put it in a compose so I can easily manage it.

I think a more reasonable question is: Why wouldn't you add a docker-compose somewhere for reference? I do not see a solid argument for not having a docker-compose available aside from it's one less file, or it could be done directly in the README.

We can add the build context as well to make it even easier for people to build on their own.

@finn-block
Copy link
Collaborator

Maybe it's just a personal thing but using docker-compose to spin up a single container seems silly. Thanks for the explanation.

@finn-block finn-block merged commit a1d2549 into decentralized-identity:main Nov 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants