Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set noUnusedLocals and noUnusedParameters to true #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kg0r0
Copy link

@kg0r0 kg0r0 commented Jul 18, 2020

Fixed #3

I fixed the following error.

errors
npm run build

> @decentralized-identity/[email protected] build /Users/kg0r0/git-workspace/sidetree-ipfs-datastores
> tsc -p .

lib/azure/AzureDataStore.ts:107:19 - error TS6133: '_all' is declared but its value is never read.

107   private async * _all () {
                      ~~~~

test/azure/AzureDataStore.spec.ts:8:7 - error TS6133: 'blobServiceMock' is declared but its value is never read.

8 const blobServiceMock = require('./mocks/MockBlobStorage');
        ~~~~~~~~~~~~~~~

test/azure/AzureDataStore.spec.ts:62:11 - error TS6133: 'writeStream' is declared but its value is never read.

62       let writeStream = new WritableMemoryStream();
             ~~~~~~~~~~~

test/azure/AzureDataStore.spec.ts:64:90 - error TS6133: 'writeStream' is declared but its value is never read.

64       standin.replace(blobStore.getBlobService(), 'getBlobToStream', (stand, _name, key, writeStream, callback) => {
                                                                                            ~~~~~~~~~~~

test/azure/AzureDataStore.spec.ts:148:15 - error TS6133: 'result' is declared but its value is never read.

148         const result = await blobStore.has('something');
                  ~~~~~~


Found 5 errors.

However, I used ts-ignore in one place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set noUnusedLocals and noUnusedParameters to true and fix all errors
1 participant