Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add trustbloc driver #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fqutishat
Copy link
Contributor

closes #6

Signed-off-by: Firas Qutishat [email protected]

@fqutishat
Copy link
Contributor Author

@peacekeeper can you review this PR

@peacekeeper
Copy link
Member

peacekeeper commented May 20, 2020

Hey @fqutishat, I tried it and it seems to work, but I would be curious about your thoughts on the following:

  1. Regarding the "jobId" parameter, my idea was that this would only ever be used if register/update/deactivate requires multiple steps. For example, the client calls the /register endpoint, and then the response includes a "jobId", which can then be used by the client in subsequent calls. But in your example, a "jobId" is already present in the original call. Is there a reason for that? Are you using this parameter for anything?
  2. My original thought for the Universal Registrar architecture was that key pairs would be generated inside the driver, and then both the private and public key would be returned to the client. I think there is an open issue about that somewhere, but I can't find it now. In your driver, where are the private keys created and stored?
  3. I'm also curious how you are using the "didDocument" parameter that a client passes into the driver.

Maybe we can discuss this in the DIF ID WG Slack channel, or on a call..?

@fqutishat
Copy link
Contributor Author

@peacekeeper I will remove "jobId" from register request

@peacekeeper peacekeeper changed the base branch from master to main January 8, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add trustbloc driver
2 participants