Update Sync Interface #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #222 +/- ##
==========================================
+ Coverage 90.99% 91.37% +0.38%
==========================================
Files 67 67
Lines 12645 12666 +21
Branches 1260 1292 +32
==========================================
+ Hits 11506 11574 +68
+ Misses 1116 1067 -49
- Partials 23 25 +2
|
LiranCohen
force-pushed
the
lirancohen/sync-interface
branch
3 times, most recently
from
d736c44 to
3659441
Compare
… servers from tests
LiranCohen
force-pushed
the
lirancohen/sync-interface
branch
from
bd8d40a to
0143dfe
Compare
|
Talked to @LiranCohen about this PR yesterday and he's going to review and determine whether it should be closed or taken out of Draft state for review. |
|
@LiranCohen said he'll re-open later once ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP but opening it up for some input and reviews.
Goals of this PR:
This PR prepares the pull/push queues before calling sync, this will allow to test out different strategies for enqueuing syncs, and currently allows pull/push to be called async after enqueuing.
I have some ideas of changes to make to the DWN SDK/DWN Server to make sync more efficient, but will work through those in a separate PR.
Additionally, I am creating some chaos-monkey type scripts that will live in a separate repo. This will allow us to also compare syncing performance with different scenarios.
**** NOTES
I think we should enforce a minimum sync, however for certain tests this minimum should be low. I've added logic for the testing environments, but locally you currently have to pass a specific ENV variable for tests to pass. This is just temporary.
Looking for input on how best to handle this, or just remove the minimum interval from the code completely.