Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility features for markdown files #249

Merged
merged 22 commits into from
Nov 3, 2023

Conversation

mishmanners
Copy link
Contributor

Add accessibility features for all markdown based on: https://github.blog/2023-10-26-5-tips-for-making-your-github-profile-page-accessible/

Checked all markdown files in the main folder, others are all okay 😉

This Code of Conduct is adapted from the [Contributor Covenant](https://www.contributor-covenant.org),
version 2.1, available on [the contributor Convenant website](https://www.contributor-covenant.org/version/2/1/code_of_conduct.html).

Community Impact Guidelines were inspired by
[Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity).

For answers to common questions about this code of conduct, see the [FAQs on the Contributor Covenant website](https://www.contributor-covenant.org/faq). Translations are available on the [translations page](https://www.contributor-covenant.org/translations).
@codesandbox
Copy link

codesandbox bot commented Oct 30, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

@diehuxx diehuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kirahsapong kirahsapong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo in CONTRIBUTING.md. Thanks for opening this PR - kudos!

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@frankhinek
Copy link
Contributor

frankhinek commented Nov 2, 2023

@mishmanners I attempted to make the modifications @kirahsapong and @EbonyLouis requested, but it appears you have the Allowing changes to a pull request branch created from a fork disabled.

Greatly appreciate the contribution so let us know if you can make the edits and push a new commit to this PR. Thanks.

@mishmanners
Copy link
Contributor Author

I'll do that today!

@mishmanners
Copy link
Contributor Author

Should be fixed now @frankhinek

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@frankhinek frankhinek self-requested a review November 3, 2023 09:39
@frankhinek frankhinek dismissed kirahsapong’s stale review November 3, 2023 09:40

Requested changes have been implemented.

@frankhinek
Copy link
Contributor

@mishmanners I tried to resolve the merge conflicts in this PR, but it appears you'll have to rebase on the current main branch and push up a commit before this PR can be merged. The primary reason is that the "Hacktoberfest" header was already removed from README.md and this PR still contains references to that text.

Once you rebase, we should be able to merge. Thanks again for the contribution.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #249 (3611e0e) into main (b40909a) will decrease coverage by 0.07%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   90.99%   90.92%   -0.07%     
==========================================
  Files          67       69       +2     
  Lines       12645    13317     +672     
  Branches     1261     1340      +79     
==========================================
+ Hits        11506    12109     +603     
- Misses       1116     1183      +67     
- Partials       23       25       +2     
Components Coverage Δ
api 94.07% <ø> (-0.26%) ⬇️
common 95.00% <ø> (ø)
credentials 92.77% <ø> (ø)
crypto 100.00% <ø> (ø)
dids 91.58% <ø> (-0.58%) ⬇️
agent 88.16% <ø> (ø)
identity-agent 59.05% <ø> (ø)
proxy-agent 58.59% <ø> (ø)
user-agent 57.36% <ø> (ø)

@frankhinek frankhinek merged commit a227186 into decentralized-identity:main Nov 3, 2023
22 of 23 checks passed
@mishmanners
Copy link
Contributor Author

So this says merged now. All good @frankhinek? Sorry for the delay I was away for a couple of days without much internet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants