-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility features for markdown files #249
Conversation
Add accessibility features based on: https://github.blog/2023-10-26-5-tips-for-making-your-github-profile-page-accessible/
This Code of Conduct is adapted from the [Contributor Covenant](https://www.contributor-covenant.org), version 2.1, available on [the contributor Convenant website](https://www.contributor-covenant.org/version/2/1/code_of_conduct.html). Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity). For answers to common questions about this code of conduct, see the [FAQs on the Contributor Covenant website](https://www.contributor-covenant.org/faq). Translations are available on the [translations page](https://www.contributor-covenant.org/translations).
Add accessibility features based on: https://github.blog/2023-10-26-5-tips-for-making-your-github-profile-page-accessible/
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo in CONTRIBUTING.md
. Thanks for opening this PR - kudos!
@mishmanners I attempted to make the modifications @kirahsapong and @EbonyLouis requested, but it appears you have the Allowing changes to a pull request branch created from a fork disabled. Greatly appreciate the contribution so let us know if you can make the edits and push a new commit to this PR. Thanks. |
I'll do that today! |
Should be fixed now @frankhinek |
Requested changes have been implemented.
@mishmanners I tried to resolve the merge conflicts in this PR, but it appears you'll have to rebase on the current main branch and push up a commit before this PR can be merged. The primary reason is that the "Hacktoberfest" header was already removed from Once you rebase, we should be able to merge. Thanks again for the contribution. |
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 90.99% 90.92% -0.07%
==========================================
Files 67 69 +2
Lines 12645 13317 +672
Branches 1261 1340 +79
==========================================
+ Hits 11506 12109 +603
- Misses 1116 1183 +67
- Partials 23 25 +2
|
a227186
into
decentralized-identity:main
So this says merged now. All good @frankhinek? Sorry for the delay I was away for a couple of days without much internet. |
Add accessibility features for all markdown based on: https://github.blog/2023-10-26-5-tips-for-making-your-github-profile-page-accessible/
Checked all markdown files in the main folder, others are all okay 😉