Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dwn-sdk-js version to 0.2.6 and fix bugs #290

Merged
merged 17 commits into from
Nov 18, 2023

Conversation

diehuxx
Copy link

@diehuxx diehuxx commented Nov 13, 2023

Summary

This PR primarily bumps the dwn-sdk-js version from 0.2.4 to 0.2.6, fixes several bugs, and improves type safety.

@web5/agent

  • Bump package version from0.2.3 to 0.2.4
  • DEFAULT_TEST_DWN_URL changed from 'https://dwn.tbddev.org/dwn0' to 'http://localhost:3000' to improve the developer experience. A number of devs have reported issues with tests failing when running on locally checked out repos. This has consistently been caused by the TBD-hosted nodes running a version of DWN SDK that differs from what is used in Web5 JS main. Devs working with the latest commits need to run a local dwn-server anyways if they want to run tests, so this ensures that they do.
  • Bump @tbd54566975/dwn-sdk-js from 0.2.4 to 0.2.6
  • Change authorizationSigner property to signer to match the name change in DWN SDK 0.2.6.
  • Correct Type issue with DwnResponse that was missing the record response property for RecordsRead replies.

@web5/api

  • Bump package version from0.8.2 to 0.8.3
  • DEFAULT_TEST_DWN_URL was also changed to localhost for the same reasons as it was in the @web5/agent package.
  • Change authorizationSigner property to signer to match the name change in DWN SDK 0.2.6.
  • Improve Type safety by using the DwnResponse type through the DwnApi now that it was fixed in the @web5/agent package.
  • Improve Type safety with new ResponseStatus type.
  • Improve comments in DwnApi that explain how the author and target properties are used, which has caused confusion for SDK contributors.
  • Remove a workaround that was introduced to resolve an issue with dwn-server that's since been fixed.
  • Bump @tbd54566975/dwn-sdk-js from 0.2.4 to 0.2.6
  • Bump @web5/agent from 0.2.3 to 0.2.4
  • Bump @web5/user-agent from 0.2.3 to 0.2.4

dev-env

  • Bump dwn-server container image from 0.2.4 to 0.2.6

@web5/identity-agent

  • Bump package version from0.2.3 to 0.2.4
  • Bump @web5/agent from 0.2.3 to 0.2.4
  • Bump @web5/api from 0.8.2 to 0.8.3

@web5/proxy-agent

  • Bump package version from0.2.3 to 0.2.4
  • Bump @web5/agent from 0.2.3 to 0.2.4

@web5/user-agent

  • Bump package version from0.2.3 to 0.2.4
  • Bump @web5/agent from 0.2.3 to 0.2.4

Copy link

codesandbox bot commented Nov 13, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@diehuxx diehuxx force-pushed the diehuxx/dwn-sdk-js-v0.2.6 branch from f4e88d2 to a055224 Compare November 13, 2023 21:44
@diehuxx diehuxx force-pushed the diehuxx/dwn-sdk-js-v0.2.6 branch from a055224 to 5d2641e Compare November 13, 2023 21:46
Copy link
Contributor

github-actions bot commented Nov 13, 2023

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

Updated @ 2023-11-18T13:31:17.737Z - Commit: 38f5990

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #290 (345c8be) into main (2421b28) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 94.64%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   90.34%   90.41%   +0.07%     
==========================================
  Files          74       74              
  Lines       14028    14068      +40     
  Branches     1382     1379       -3     
==========================================
+ Hits        12674    12720      +46     
+ Misses       1328     1322       -6     
  Partials       26       26              
Components Coverage Δ
api 95.64% <100.00%> (+0.59%) ⬆️
common 95.00% <ø> (ø)
credentials 94.49% <ø> (ø)
crypto 100.00% <100.00%> (ø)
dids 88.75% <ø> (ø)
agent 87.22% <45.45%> (ø)
identity-agent 56.81% <100.00%> (ø)
proxy-agent 58.43% <100.00%> (ø)
user-agent 55.22% <ø> (ø)

@frankhinek
Copy link
Contributor

frankhinek commented Nov 18, 2023

Removed runtimeVersion from the launch.json files to prevent debugging from erroring out on systems that don't have or use different Node.js version managers (e.g., volta).

Screenshot 2023-11-17 at 7 55 34 PM

@frankhinek frankhinek changed the title Bump dwn-sdk-js version Bump dwn-sdk-js version to 0.2.6 and fix bugs Nov 18, 2023
@frankhinek frankhinek force-pushed the diehuxx/dwn-sdk-js-v0.2.6 branch from f2435fc to a42cb0d Compare November 18, 2023 13:25
@frankhinek frankhinek force-pushed the diehuxx/dwn-sdk-js-v0.2.6 branch from a42cb0d to 345c8be Compare November 18, 2023 13:28
@frankhinek frankhinek added the bug Something isn't working label Nov 18, 2023
@frankhinek frankhinek added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Nov 18, 2023
@frankhinek frankhinek merged commit 50c27ec into main Nov 18, 2023
23 of 25 checks passed
@frankhinek frankhinek deleted the diehuxx/dwn-sdk-js-v0.2.6 branch November 18, 2023 14:16
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* This PR primarily bumps the dwn-sdk-js version from 0.2.4 to 0.2.6, fixes several bugs, and improves type safety.
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* This PR primarily bumps the dwn-sdk-js version from 0.2.4 to 0.2.6, fixes several bugs, and improves type safety.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record returned from a read or query always shows author as currently connected DID
3 participants