Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up ci #308

Closed
wants to merge 2 commits into from
Closed

speed up ci #308

wants to merge 2 commits into from

Conversation

shamilovtim
Copy link
Contributor

@shamilovtim shamilovtim commented Nov 21, 2023

Reason for PR

  • CI was running slow. checked the CI steps and saw that node_modules wasn't being cached.
  • reinstalling npm globally wasn't necessary as v18 LTS ships a modern version of npm
  • actions can be bumped to latest versions

Solution

  • cache node_modules. the cache invalidation of actions/setup-node says it supports npm workspaces and works as-is with symlinked projects.
  • remove npm install -g npm CI step
  • bump action versions to v4
  • include deflake web tests #307

Copy link

codesandbox bot commented Nov 21, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

github-actions bot commented Nov 21, 2023

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

Updated @ 2023-11-21T08:17:58.921Z - Commit: 91b613f

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #308 (4c7c663) into main (9af892a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          74       74           
  Lines       14072    14072           
  Branches     1387     1387           
=======================================
  Hits        12778    12778           
  Misses       1269     1269           
  Partials       25       25           
Components Coverage Δ
api 96.68% <ø> (ø)
common 95.00% <ø> (ø)
credentials 94.49% <ø> (ø)
crypto 100.00% <ø> (ø)
dids 88.75% <ø> (ø)
agent 88.07% <ø> (ø)
identity-agent 56.81% <ø> (ø)
proxy-agent 58.43% <ø> (ø)
user-agent 55.22% <ø> (ø)

@shamilovtim
Copy link
Contributor Author

This made zero difference. It was the web tests with the timeout / retry that were taking forever.

@frankhinek frankhinek deleted the tshamilov/speed-up-ci branch February 5, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant