generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Karma with Web Test Runner #316
Merged
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
64843fc
poc: web test runner
shamilovtim 7d96ca7
add ci test
shamilovtim ca19c8b
webkit is hanging
shamilovtim c43850a
naming
shamilovtim c09d2f7
shutoff webkit
shamilovtim a04ac05
unbump playwright
shamilovtim 9e93208
remove manual timeouts
shamilovtim 56cf9d0
use concurrency 1
shamilovtim b075b1c
wrap up poc
shamilovtim 41ae6ec
run CI for poc back to back with previous impl
shamilovtim f48c325
tie up loose ends
shamilovtim aacf06c
let wtr run to compare
shamilovtim 7566abc
Merge branch 'main' into tshamilov/web-test-runner
shamilovtim 210b693
add back webkit. apples to apples with karma.
shamilovtim 138c155
Merge branch 'main' into tshamilov/web-test-runner
shamilovtim cfdd6a3
remove karma
shamilovtim bb9d6ce
remove karma
shamilovtim 1a374f3
fix tbdocs (i assume)
shamilovtim de7ee5d
update ci config
shamilovtim 092f1b9
better naming of scripts
shamilovtim d99e6de
fix node
shamilovtim defbbf7
revert test config changes
shamilovtim 1e861f6
fix env var override
shamilovtim 1ee3e5a
cleanup ci config
shamilovtim df95935
cleanup explicit deps
shamilovtim 489f2a5
Merge branch 'main' into tshamilov/web-test-runner
shamilovtim 9902026
add back playwright
shamilovtim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shamilovtim pretty sure we need to keep the
@playwright/test
dev dependencies.every time we've tried to remove them in the past and only have
@playwright/test
as a dev dep, someone reports issues running tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done