-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decouple tbdocs commenter #323
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 73 73
Lines 15764 15764
Branches 1448 1448
=======================================
Hits 14468 14468
Misses 1270 1270
Partials 26 26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this run on push
only rather than on every commit of every PR?
on:
push:
branches:
- main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught up with @leordev about getting the next step done after this which is to publish the API docs to gh-pages. Hope to get that prioritized for next week.
* decouple tbdocs commenter * trigger comment * Decouple docs actions
* decouple tbdocs commenter * trigger comment * Decouple docs actions
Now we also have the tbdocs report in the GH Action summary!
https://github.com/TBD54566975/web5-js/actions/runs/7039346479?pr=323#summary-19158131202
workflow_run
trigger to safely execute code from the main branch, access secrets and be able to create the report commentPS: the tbdocs report comment in the PR will only start to show up when we merge this PR to main. Unfortunately this is the normal behavior for new
workflow_run
definitions.Working evidence: