speed up ci #325
Merged
speed up ci #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilovtim
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
TBDocs Report ✅ No errors or warnings @web5/api
TBDocs Report Updated at 2023-12-11T22:22:11Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 92.80% 92.82% +0.01%
==========================================
Files 76 76
Lines 17267 17267
Branches 1607 1607
==========================================
+ Hits 16025 16028 +3
+ Misses 1215 1212 -3
Partials 27 27
|
shamilovtim
force-pushed
the
tshamilov/ci-speed
branch
from
8655c19 to
c5dece6
Compare
shamilovtim
force-pushed
the
tshamilov/ci-speed
branch
2 times, most recently
from
267582e to
6d83857
Compare
This reverts commit 5371e54.
shamilovtim
force-pushed
the
tshamilov/ci-speed
branch
from
aa2b619 to
b30bb0b
Compare
frankhinek
suggested changes
Dec 6, 2023
There was a problem hiding this comment.
Nice work @shamilovtim ! Will be great to speed up the test runs for future PRs.
|
resolved @frankhinek |
frankhinek
approved these changes
Dec 12, 2023
mistermoe
approved these changes
Dec 12, 2023
Merged
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* remove unnecessary npm install * add npm caching * cache playwright * use newer env var api * fix naming * add native dwn server * run dwn server natively * cleanup bg processing * dial in the browser build * better naming * add parallelism * fix parallelism * better naming * weird bug * cleaner parallel config * fix * fix * harden agent test * solidify parallel groups * do another run * add comment * balance parallel groups * browser groups * Revert "browser groups" This reverts commit 5371e54. * merge * pr review: pin commit hashes * pr review: pin commit hashes * rebase
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* remove unnecessary npm install * add npm caching * cache playwright * use newer env var api * fix naming * add native dwn server * run dwn server natively * cleanup bg processing * dial in the browser build * better naming * add parallelism * fix parallelism * better naming * weird bug * cleaner parallel config * fix * fix * harden agent test * solidify parallel groups * do another run * add comment * balance parallel groups * browser groups * Revert "browser groups" This reverts commit 5371e54. * merge * pr review: pin commit hashes * pr review: pin commit hashes * rebase
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* remove unnecessary npm install * add npm caching * cache playwright * use newer env var api * fix naming * add native dwn server * run dwn server natively * cleanup bg processing * dial in the browser build * better naming * add parallelism * fix parallelism * better naming * weird bug * cleaner parallel config * fix * fix * harden agent test * solidify parallel groups * do another run * add comment * balance parallel groups * browser groups * Revert "browser groups" This reverts commit 5371e54. * merge * pr review: pin commit hashes * pr review: pin commit hashes * rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for PR
CI runs especially on the
test-with-browsersjob were taking between 15 to 25 minutes. Some common optimizations were unimplemented and parallelism was not being used for tests despite GH for open source being free.Implementation
node(see: introduce npx dwn-server#94)Results