Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @web5/dids version and improve DID spec compliance #353

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

frankhinek
Copy link
Contributor

@frankhinek frankhinek commented Dec 15, 2023

This PR will:

@web5/dids

  • bump the version to 0.2.4
  • Remove the contentType property from DidResolutionResult returned by the DidResolver.resolve function
    • Per the DID Core spec:

      This property MUST NOT be present if the resolve function was called

  • Improves spec compliance of the DidDereferencingResult type.
  • Returns the spec defined values for dereferencingMetadata and adds a DidDereferencingMetadata type.
  • Improves test coverage for the DidResolver.dereference() function to include validating return of service DID resources.
  • Adds more docs to DID resolution / dereference types and implementations.

@web5/credentials

  • bump the version to 0.4.1 so that a new release can be published to NPM Registry which depends on @web5/[email protected]

@web5/*

@frankhinek frankhinek added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Dec 15, 2023
@frankhinek frankhinek self-assigned this Dec 15, 2023
Copy link

codesandbox bot commented Dec 15, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link
Contributor

github-actions bot commented Dec 15, 2023

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

TBDocs Report Updated at 2023-12-15T01:26:10Z 176b147

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #353 (176b147) into main (edc8054) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #353      +/-   ##
==========================================
+ Coverage   92.73%   92.79%   +0.05%     
==========================================
  Files          71       71              
  Lines       16473    16477       +4     
  Branches     1521     1525       +4     
==========================================
+ Hits        15277    15290      +13     
+ Misses       1174     1165       -9     
  Partials       22       22              
Components Coverage Δ
api 96.93% <ø> (ø)
common 97.78% <ø> (ø)
credentials ∅ <ø> (∅)
crypto 100.00% <ø> (ø)
dids 92.24% <100.00%> (+0.37%) ⬆️
agent 88.08% <ø> (ø)
identity-agent 56.81% <ø> (ø)
proxy-agent 58.43% <ø> (ø)
user-agent 55.22% <ø> (ø)

@frankhinek frankhinek merged commit c351302 into main Dec 15, 2023
30 checks passed
@frankhinek frankhinek deleted the bump-dids-version branch December 15, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants