Adding credentials.verify #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
TBDocs Report ✅ No errors or warnings @web5/api
TBDocs Report Updated at 2023-12-21T19:47:51Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 71 71
Lines 16477 16477
Branches 1525 1525
=======================================
Hits 15290 15290
Misses 1165 1165
Partials 22 22
|
frankhinek
approved these changes
Jan 10, 2024
Comment on lines
+421
to
+422
| // TODO: DID:JWK is not supported yet | ||
| if (description === 'verify a jwt verifiable credential signed with a did:jwk') { |
There was a problem hiding this comment.
@nitro-neal can you add an issue in the web5-js repo to ensure we double back and remove this conditional skip once a did:jwk is merged for @web5/dids?
mistermoe
approved these changes
Jan 11, 2024
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding credentials.verify test vector.
This will give us checkmarks here - https://tbd54566975.github.io/sdk-development/ for credentials.verify