Bump dwn-sdk-js to version 0.2.10
#370
Conversation
LiranCohen
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
TBDocs Report ✅ No errors or warnings @web5/api
TBDocs Report Updated at 2024-01-09T23:51:50Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
+ Coverage 91.69% 91.86% +0.17%
==========================================
Files 67 67
Lines 18176 18163 -13
Branches 1534 1543 +9
==========================================
+ Hits 16667 16686 +19
+ Misses 1487 1454 -33
- Partials 22 23 +1
|
| @@ -239,7 +238,7 @@ export class SyncManagerLevel implements SyncManager { | |||
|
|
|||
| for (let job of pushJobs) { | |||
| const [key] = job; | |||
| const [did, dwnUrl, watermark, messageCid] = key.split('~'); | |||
| const [did, dwnUrl, _, messageCid] = key.split('~'); | |||
There was a problem hiding this comment.
@LiranCohen Is there a reason we're still using the watermark in the key?
In other words, why not delete it rather than assigning it to a value we don't use? (_)
There was a problem hiding this comment.
@frankhinek Yeah, so the events come in the order they should be inserted when doing a EventsGet. We then stick them in a LevelDB queue, to read here. The queue is sorted by the key, so the watermark here is used to sort it in the order it should be applied.
|
Thanks @frankhinek! I think I've addressed the formatting issues. |
This PR updates the
dwn-sdk-jslibrary to the version0.2.10With this update come:
RecordsWrite, removing the need for awritePrunedRecordmethod in thedwn-managerUnionMessageReplyto properly represent a union type of all replies.EventLog, no longer tracking an external watermark, but rather an internal one.