Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CodeQL SAST #383

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Setup CodeQL SAST #383

merged 2 commits into from
Feb 2, 2024

Conversation

leordev
Copy link
Contributor

@leordev leordev commented Jan 19, 2024

Copy link

codesandbox bot commented Jan 19, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Contributor

github-actions bot commented Jan 19, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

TBDocs Report Updated at 2024-01-25T18:12:46Z baa8a2a

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Merging #383 (baa8a2a) into main (25f1d03) will increase coverage by 91.90%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #383       +/-   ##
=========================================
+ Coverage      0   91.90%   +91.90%     
=========================================
  Files         0       67       +67     
  Lines         0    18241    +18241     
  Branches      0     1550     +1550     
=========================================
+ Hits          0    16764    +16764     
- Misses        0     1454     +1454     
- Partials      0       23       +23     
Components Coverage Δ
agent 88.71% <ø> (∅)
api 96.94% <ø> (∅)
common 98.57% <ø> (∅)
credentials ∅ <ø> (∅)
crypto 94.60% <ø> (∅)
dids 92.24% <ø> (∅)
identity-agent 56.81% <ø> (∅)
crypto-aws-kms 100.00% <ø> (∅)
proxy-agent 58.43% <ø> (∅)
user-agent 55.22% <ø> (∅)

Copy link
Contributor

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leordev leordev mentioned this pull request Jan 25, 2024

steps:
- name: Checkout repository
uses: actions/checkout@v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a security related tool, it should likely used Pinned Dependencies 😄

Otherwise we get dinged here: https://github.com/TBD54566975/web5-js/security/code-scanning/9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 🙏

.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
.github/workflows/codeql.yml Outdated Show resolved Hide resolved
@leordev leordev requested a review from frankhinek January 25, 2024 18:10
@frankhinek frankhinek merged commit ebcb40a into main Feb 2, 2024
34 checks passed
@frankhinek frankhinek deleted the leordev/sast branch February 2, 2024 18:01
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* Setup CodeQL SAST
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* Setup CodeQL SAST
finn-block pushed a commit that referenced this pull request Mar 19, 2024
* Setup CodeQL SAST
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants