-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup CodeQL SAST #383
Setup CodeQL SAST #383
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
TBDocs Report ✅ No errors or warnings @web5/api
TBDocs Report Updated at 2024-01-25T18:12:46Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=========================================
+ Coverage 0 91.90% +91.90%
=========================================
Files 0 67 +67
Lines 0 18241 +18241
Branches 0 1550 +1550
=========================================
+ Hits 0 16764 +16764
- Misses 0 1454 +1454
- Partials 0 23 +23
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
.github/workflows/codeql.yml
Outdated
|
||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a security related tool, it should likely used Pinned Dependencies 😄
Otherwise we get dinged here: https://github.com/TBD54566975/web5-js/security/code-scanning/9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! 🙏
Similar to TBD54566975/tbdex-js#146
Which, btw, solves https://github.com/TBD54566975/web5-js/security/code-scanning/24