generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several minor issues in @web5/dids
#414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
requested review from
LiranCohen,
nitro-neal,
amika-sq and
jiyoonie9
February 15, 2024 21:13
mistermoe
approved these changes
Feb 15, 2024
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
TBDocs Report Updated at 2024-02-15T21:19:09Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
- Coverage 93.37% 93.37% -0.01%
==========================================
Files 79 79
Lines 23776 23796 +20
Branches 1894 1894
==========================================
+ Hits 22202 22219 +17
- Misses 1534 1537 +3
Partials 40 40
|
nitro-neal
reviewed
Feb 15, 2024
nitro-neal
approved these changes
Feb 15, 2024
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Fix several minor issues * Bump @web5/dids to 0.4.1 --------- Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Fix several minor issues * Bump @web5/dids to 0.4.1 --------- Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Fix several minor issues * Bump @web5/dids to 0.4.1 --------- Signed-off-by: Frank Hinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
DidMethodApi
generics.getSigningMethod()
toDidMethodApi
to ensure all implementations include it.verificationMethods
type inDidJwk
andDidKey
to be consistent withDidDht
.@web5/dids
to0.4.1
so that the changes can be published to NPM Registry.Important
Should be merged after #413