generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to pnpm and fix CVE for ip transitive dependency #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilovtim
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
February 20, 2024 20:24
shamilovtim
changed the title
fix CVE for ip transitive dependency
move to pnpm and fix CVE for ip transitive dependency
Feb 21, 2024
shamilovtim
changed the title
move to pnpm and fix CVE for ip transitive dependency
migrate to pnpm and fix CVE for ip transitive dependency
Feb 21, 2024
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-02-23T09:21:58Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 80 80
Lines 23804 23804
Branches 1890 1890
=======================================
Hits 22220 22220
Misses 1544 1544
Partials 40 40
|
frankhinek
reviewed
Feb 22, 2024
frankhinek
reviewed
Feb 22, 2024
frankhinek
reviewed
Feb 22, 2024
frankhinek
reviewed
Feb 22, 2024
frankhinek
reviewed
Feb 22, 2024
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
reviewed
Feb 22, 2024
frankhinek
reviewed
Feb 22, 2024
frankhinek
reviewed
Feb 22, 2024
frankhinek
reviewed
Feb 22, 2024
Co-authored-by: Frank Hinek <[email protected]>
Co-authored-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
approved these changes
Feb 23, 2024
mistermoe
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Sry for formatting issues. Reviewed on mobile
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* fix CVE for ip transitive dependency * migrate to pnpm * Update CONTRIBUTING.md * Fix ordering of clean script * Consistent use of quotation marks in GH workflows * Add version comments to pinned GH workflow actions --------- Signed-off-by: Frank Hinek <[email protected]> Co-authored-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* fix CVE for ip transitive dependency * migrate to pnpm * Update CONTRIBUTING.md * Fix ordering of clean script * Consistent use of quotation marks in GH workflows * Add version comments to pinned GH workflow actions --------- Signed-off-by: Frank Hinek <[email protected]> Co-authored-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* fix CVE for ip transitive dependency * migrate to pnpm * Update CONTRIBUTING.md * Fix ordering of clean script * Consistent use of quotation marks in GH workflows * Add version comments to pinned GH workflow actions --------- Signed-off-by: Frank Hinek <[email protected]> Co-authored-by: Frank Hinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
happy to rebase this if anyone needs to merge things first
@web/test-runner
as soon as a patched release is available #407closes #409