updates to verify #421
Merged
updates to verify #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
|
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-03-14T21:46:00Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
- Coverage 93.35% 93.34% -0.01%
==========================================
Files 80 80
Lines 23839 23968 +129
Branches 1891 1916 +25
==========================================
+ Hits 22255 22374 +119
- Misses 1544 1551 +7
- Partials 40 43 +3
|
mistermoe
reviewed
Feb 27, 2024
|
Let me add these test vectors to double check on this impl |
| } | ||
|
|
||
| // TODO: iss is optional? | ||
| if (!iss) throw new Error('Verification failed: iss claim is required'); |
There was a problem hiding this comment.
lol ok, just saw this: - https://www.w3.org/TR/vc-data-model/#jwt-decoding
If iss is present, the value MUST be used to set the issuer [property](https://www.w3.org/TR/vc-data-model/#dfn-property) of the new [credential](https://www.w3.org/TR/vc-data-model/#dfn-credential) JSON object or the holder [property](https://www.w3.org/TR/vc-data-model/#dfn-property) of the new [presentation](https://www.w3.org/TR/vc-data-model/#dfn-presentations) JSON object.
| } | ||
|
|
||
| // jti MUST represent the id property of the verifiable credential or verifiable presentation. | ||
| if(jti && jti !== vcTyped.id) { |
There was a problem hiding this comment.
what if there's no jti? shoudl we err?
There was a problem hiding this comment.
so it seems like all of them are optional even iss, but yea iss is the only one we require currently
decentralgabe
approved these changes
Feb 29, 2024
|
@mistermoe I added your test vectors - https://github.com/TBD54566975/web5-spec/tree/main/test-vectors/vc_jwt |
frankhinek
approved these changes
Mar 15, 2024
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* updates to verify * merge * updates * remove comment * merge and timestamp update * lint update * updates
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* updates to verify * merge * updates * remove comment * merge and timestamp update * lint update * updates
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
* updates to verify * merge * updates * remove comment * merge and timestamp update * lint update * updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing:
#420
Made sure we are explicitly checking these:
updated the iss to be the did's id and not the vcDataModel issuer
Examples:
vcJwt:
Decoded JWT:
ParsedJwt (VcDataModel):
Example processing rules:
jti
jti: 123
payload.vc.id: 123
valid? ✅
jti: 123
payload.vc.id: undefined
valid? ✅
jti: 123
payload.vc.id: 321
valid? ❌
jti: 123
payload.vc.id: “” // empty string
valid? ❌