fix a couple of actions and bump #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamilovtim
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
|
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-03-11T17:40:41Z |
shamilovtim
commented
Mar 6, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #437 +/- ##
==========================================
- Coverage 93.35% 93.34% -0.02%
==========================================
Files 80 80
Lines 23831 23831
Branches 1891 1891
==========================================
- Hits 22247 22244 -3
- Misses 1544 1547 +3
Partials 40 40
|
frankhinek
reviewed
Mar 11, 2024
frankhinek
reviewed
Mar 11, 2024
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
reviewed
Mar 11, 2024
frankhinek
approved these changes
Mar 11, 2024
csuwildcat
approved these changes
Mar 11, 2024
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
fix a couple of actions and bump --------- Signed-off-by: Frank Hinek <[email protected]> Co-authored-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
fix a couple of actions and bump --------- Signed-off-by: Frank Hinek <[email protected]> Co-authored-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
fix a couple of actions and bump --------- Signed-off-by: Frank Hinek <[email protected]> Co-authored-by: Frank Hinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the
node:testaction failed on main from Add hermit and update GH actions #436 where there was a bump to Node v20.Also noticed that a couple of the CI steps were still using node v18, so I have updated those to also use the same setup as what was introduced in Add hermit and update GH actions #436.
I also bumped the actions versions to newer ones
There is a perceptible regression in node performance between node v18 and node v20 which caused the
SyncManagerLeveltest timeout to be exceeded. By bumping the timeout of theagenttest suite I was able to account for the larger test time.I was able to parallelize
test-with-nodewhich reduced that CI step's runtime by about 8%The mocha junit reporter is obscuring test results on CI so failures are unknown at the moment. I think this is an outstanding problem, and the junit reporter is doing more harm than good.