Fix VSCode workspace paths after switch to pnpm #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Hinek <[email protected]>
frankhinek
requested review from
LiranCohen,
thehenrytsai,
csuwildcat,
mistermoe,
jiyoonie9 and
diehuxx
as code owners
|
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-03-12T18:20:41Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 80 80
Lines 23839 23839
Branches 1891 1891
=======================================
Hits 22255 22255
Misses 1544 1544
Partials 40 40
|
csuwildcat
approved these changes
Mar 12, 2024
LiranCohen
approved these changes
Mar 12, 2024
shamilovtim
approved these changes
Mar 12, 2024
mistermoe
approved these changes
Mar 15, 2024
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Frank Hinek <[email protected]>
finn-block
pushed a commit
that referenced
this pull request
Mar 19, 2024
Signed-off-by: Frank Hinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will:
rootto package-specific workspace paths for the Mocha binary which restores ability to use VSCode debugging.Context
When the Web5 JS monorepo was migrated from
npmtopnpmone of the consequences is that rootnode_modulesdirectory no longer contains the kitchen sink of every dependency used by every package in the monorepo. As a result, the path reference in each package'slaunch.jsonfor the Mocha binary is no longer valid.