-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status List Credential Implementation #448
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
- Coverage 93.35% 93.34% -0.01%
==========================================
Files 80 81 +1
Lines 23831 24083 +252
Branches 1891 1915 +24
==========================================
+ Hits 22247 22481 +234
- Misses 1544 1562 +18
Partials 40 40
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job on this. the most important thing is to get this into web5 specs with some tests to make sure we can check statuses consistently across impls
🦋 Changeset detectedLatest commit: 2e21b51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-05-23T19:32:44Z |
Adding test vectors here https://github.com/TBD54566975/web5-spec/pull/151/files |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
==========================================
+ Coverage 90.87% 90.89% +0.01%
==========================================
Files 118 119 +1
Lines 29744 30005 +261
Branches 2214 2237 +23
==========================================
+ Hits 27029 27272 +243
- Misses 2680 2698 +18
Partials 35 35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @nitro-neal, I am going to create a PR to your PR for you to review! 🤣
#486
Updated and merged in your updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the tbdocs warning yo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, except for that typedoc warning... I thought I turned it into an error instead of warning. Maybe this is still running off of old code... will investigate if it continues to be like this.
spec update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
StatusListCredential
represents a digitally verifiable status list credential according to the W3C Verifiable Credentials Status List v2021.When a status list is published, the result is a verifiable credential that encapsulates the status list.
Implements status list credential
create
andvalidateCredentialInStatusList
create
validateCredentialInStatusList
Closes: #380