generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump DID package version and consume with creds #456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
jiyoonie9,
diehuxx,
mistermoe,
frankhinek and
csuwildcat
as code owners
March 21, 2024 19:21
nitro-neal
changed the title
update dids version and consume with creds
Bump DID package version and consume with creds
Mar 21, 2024
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-03-21T19:23:55Z |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
Coverage 93.35% 93.35%
=======================================
Files 80 80
Lines 23950 23950
Branches 1916 1916
=======================================
Hits 22359 22359
Misses 1548 1548
Partials 43 43
|
Approve/merge after: |
shamilovtim
approved these changes
Mar 21, 2024
csuwildcat
approved these changes
Mar 21, 2024
thehenrytsai
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
frankhinek
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the did version and updates the creds package to consume it and use the
UniversalResolver
classThis bumps the dids package version to:
This also updates the credentials package to use the
0.4.2
dids package and consume theUniversalResolver
class