Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web5-js error message from vectors and point to latest test vectors #473

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Remove web5-js error message from vectors and point to latest test vectors #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ac278e
updates
nitro-neal Apr 1, 2024
a23b1a6
fix lint
nitro-neal Apr 1, 2024
5a50cde
updates
nitro-neal Apr 1, 2024
d4b70bf
update
nitro-neal Apr 1, 2024
0a4e64d
update hash
nitro-neal Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/credentials/tests/jwt.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,18 +208,14 @@ describe('Jwt', () => {
const vectors = JwtVerifyTestVector.vectors;

for (const vector of vectors) {
const { input, errors, errorMessage } = vector;
const { input, errors } = vector;

if (errors) {
let errorOccurred = false;
try {
await VerifiableCredential.verify({ vcJwt: input });
} catch (e: any) {
errorOccurred = true;
expect(e.message).to.not.be.null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this message text is already verified in the web5-js unit tests yeah?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, it is not being covered by unit tests

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue tracked decentralized-identity/web5-spec#147

if(errorMessage && errorMessage['web5-js']) {
expect(e.message).to.include(errorMessage['web5-js']);
}
}
if (!errorOccurred) {
throw new Error('Verification should have failed but didn\'t.');
Expand Down
2 changes: 1 addition & 1 deletion web5-spec
Open in desktop
Submodule web5-spec updated from 1f0c51 to 270966
Loading