-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated DID:DHT implementation to be compliant with vector 1 #504
Conversation
thehenrytsai
commented
May 1, 2024
•
edited
Loading
edited
- Updated DID:DHT implementation to be compliant with vector 1
- Added self to default owners in CODEOWNERS
- Opportunistic QoL update: excluded generated files from search results
- Opportunistic QoL update:: allow one click debugging for DID project
🦋 Changeset detectedLatest commit: 7272955 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-05-01T20:34:13Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 90.56% 90.81% +0.24%
==========================================
Files 112 116 +4
Lines 29117 29414 +297
Branches 2085 2156 +71
==========================================
+ Hits 26370 26711 +341
+ Misses 2712 2668 -44
Partials 35 35
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! +1 to @nitro-neal's comment, I would love to see the new test vectors added to the web5-spec