Add a helper method for generating a PaginationCursor #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ff15c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-05-08T01:29:54Z |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 91.04% 91.06% +0.01%
==========================================
Files 116 116
Lines 29562 29603 +41
Branches 2177 2185 +8
==========================================
+ Hits 26915 26958 +43
+ Misses 2612 2610 -2
Partials 35 35
|
LiranCohen
requested review from
frankhinek,
csuwildcat,
mistermoe,
shamilovtim,
nitro-neal and
thehenrytsai
as code owners
shamilovtim
reviewed
May 7, 2024
shamilovtim
reviewed
May 7, 2024
shamilovtim
previously approved these changes
May 7, 2024
LiranCohen
force-pushed
the
lirancohen/message-cid-pagination-tools
branch
from
60ef86a to
c367517
Compare
shamilovtim
approved these changes
May 8, 2024
Merged
nitro-neal
pushed a commit
that referenced
this pull request
May 13, 2024
Currently the only way to get a pagination cursor is from a query response that has more than the number of records you've queried for. However there could be some cases where the user wants to keep track of the last record they have retrieved and retrieve subsequent records. Added some helper methods to `agent` in order to build/return the data needed, and a convenience method to the `Record` class in `api` that utilizes them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only way to get a pagination cursor is from a query response that has more than the number of records you've queried for.
However there could be some cases where the user wants to keep track of the last record they have retrieved and retrieve subsequent records.
Added some helper methods to
agentin order to build/return the data needed, and a convenience method to theRecordclass inapithat utilizes them.