Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated playwright dependencies + pnpm-lock.yaml + broken test #789

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

thehenrytsai
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Jul 23, 2024

⚠️ No Changeset found

Latest commit: 0128751

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 23, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-07-23T18:03:42Z 0128751

Copy link
Contributor

@shamilovtim shamilovtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confused about this because we don't use permissive version specifiers. How are we updating the lockfile independently of the package.json versions?

Could we maybe go back to transparent and intentional dependency updates? The last time multiformats was bumped out of sync with the rest of the TBD repos it blew up the wallet and resolved 3+ versions of multiformats in our projects.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (52c3748) to head (0128751).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #789   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files         109      109           
  Lines       29998    29998           
  Branches     2321     2321           
=======================================
  Hits        27839    27839           
  Misses       2122     2122           
  Partials       37       37           
Components Coverage Δ
agent 85.22% <ø> (ø)
api 98.99% <ø> (ø)
common 98.68% <ø> (ø)
credentials 94.95% <ø> (ø)
crypto 93.81% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.70% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.70% <ø> (ø)
user-agent 96.70% <ø> (ø)

@thehenrytsai thehenrytsai marked this pull request as draft July 23, 2024 15:29
@thehenrytsai thehenrytsai marked this pull request as ready for review July 23, 2024 19:31
@thehenrytsai thehenrytsai changed the title Updated pnpm-lock.yaml for updated dependencies Updated playwright dependencies + pnpm-lock.yaml + broken test Jul 23, 2024
@thehenrytsai
Copy link
Contributor Author

@shamilovtim, see #790 on current issue with dependabot. Would love for someone to help fixing it, feel free to assign it to yourself if you feel passionate about it! 🙏

@thehenrytsai thehenrytsai merged commit 80d5663 into main Jul 23, 2024
35 checks passed
@thehenrytsai thehenrytsai deleted the henrytsai/dependencies-2024-07-22 branch July 23, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants