-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated playwright
dependencies + pnpm-lock.yaml + broken test
#789
Conversation
|
TBDocs Report ✅ No errors or warnings @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-07-23T18:03:42Z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confused about this because we don't use permissive version specifiers. How are we updating the lockfile independently of the package.json versions?
Could we maybe go back to transparent and intentional dependency updates? The last time multiformats was bumped out of sync with the rest of the TBD repos it blew up the wallet and resolved 3+ versions of multiformats in our projects.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #789 +/- ##
=======================================
Coverage 92.80% 92.80%
=======================================
Files 109 109
Lines 29998 29998
Branches 2321 2321
=======================================
Hits 27839 27839
Misses 2122 2122
Partials 37 37
|
playwright
dependencies + pnpm-lock.yaml + broken test
@shamilovtim, see #790 on current issue with dependabot. Would love for someone to help fixing it, feel free to assign it to yourself if you feel passionate about it! 🙏 |
No description provided.