-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SyncEngineLevel respects most recent startSync interval. #887
Conversation
|
TBDocs Report 🛑 Errors: 0 @web5/api
@web5/crypto
@web5/crypto-aws-kms
@web5/dids
@web5/credentials
TBDocs Report Updated at 2024-09-04T22:47:48Z |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #887 +/- ##
=======================================
Coverage 93.42% 93.43%
=======================================
Files 117 117
Lines 33260 33279 +19
Branches 2663 2668 +5
=======================================
+ Hits 31072 31093 +21
+ Misses 2149 2147 -2
Partials 39 39
|
- Add a missing changset for #887: `stopSync` now blocks if a current sync is in progress before clearing the interval. An optional timeout can be defined, the default is 2 seconds. After this timeout it will throw. TestHarness has been updated to stop sync before clearing storage, previously this caused an issue where an ongoing sync would attempt to sign messages for DID that no longer had keys after clearing storage. #890 has been created to better address this by creating a signal to gracefully stop sync immediately.
This PR slightly modifies the way sync works.