Validate presentaion submission with new validator #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitro-neal
requested review from
andresuribe87,
mistermoe,
tomdaffurn and
phoebe-lew
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #208 +/- ##
==========================================
+ Coverage 79.91% 80.16% +0.24%
==========================================
Files 37 37
Lines 2166 2193 +27
Branches 299 309 +10
==========================================
+ Hits 1731 1758 +27
Misses 297 297
Partials 138 138
|
| } | ||
|
|
||
| if (descriptor.id != id) { | ||
| throw PexValidationException("Each descriptor should have one id in it, on all levels") |
There was a problem hiding this comment.
also need to check that descriptor ids are unique within the definition
angiejones
reviewed
Jan 25, 2024
credentials/src/main/kotlin/web5/sdk/credentials/PresentationExchange.kt
Show resolved
Hide resolved
phoebe-lew
approved these changes
Feb 5, 2024
| * Throws an [PexValidationException] if the provided object does not conform to the Presentation Definition | ||
| */ | ||
| @Throws(PexValidationException::class) | ||
| public fun validateSubmission(presentationSubmission: PresentationSubmission) { |
There was a problem hiding this comment.
should this specify that it's for v2 like the PD one above?
There was a problem hiding this comment.
Nope there is only one version of submission and honestly we should probably remove the v2 from definition since I think we will only be using v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method performs several checks to ensure the integrity of the presentation submission model object:
Usage:
web5-spec vector change - decentralized-identity/web5-spec#109