Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dwn-sdk-js to latest version #138

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Update dwn-sdk-js to latest version #138

merged 6 commits into from
Oct 4, 2023

Conversation

amika-sq
Copy link
Contributor

@amika-sq amika-sq commented Oct 3, 2023

Resolves #106

Bumped the @tbd54566975/dwn-sdk-js package to the latest 0.2.3 version. This allows us to remove the local patch, because the dwn-sdk-js now no longer exports the various level stores behind a named export.

This necessitated the update of the @web5 packages as well, as the changes to the dwn-sdk necessitated changes. They're now all pointing to alpha packages, which has the necessary changes in them. I'll make another task in the backlog to update those once published.

There were two changes that I made to the code:

  • DWN creation now resolves to a Level interface, instead of a wrapper. Our ExpoLevel implementation already supports this, it just needed to be typed appropriately.
    • This caused the DWN code to grow a little bit. I pulled it out into it's own dwn feature, so it wouldn't get lost within the identity code. Happy to change this back if we think it's unnecessary.
  • RecordsRead callsite had to update to now take a filter which contains a recordId, instead of the old way of providing just a recordId

@amika-sq amika-sq requested a review from shamilovtim October 3, 2023 22:45
@amika-sq amika-sq linked an issue Oct 3, 2023 that may be closed by this pull request
@amika-sq amika-sq merged commit bdf0af7 into main Oct 4, 2023
@amika-sq amika-sq deleted the amika/bump-dwn branch October 4, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump dwn-sdk-js to v0.2.2 and remove patch
2 participants