Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linstor] Improvement of LINSTOR database backup management #187

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

[linstor] Improvement of LINSTOR database backup management #187

wants to merge 30 commits into from

Conversation

NikolayDemchuk
Copy link
Contributor

@NikolayDemchuk NikolayDemchuk commented Oct 1, 2024 •
edited
Loading

Signed-off-by: Nikolay Demchuk [email protected]

Description

Add weekly backups of LINSTOR DB, change retention period.

Why do we need it, and what problem does it solve?

Backups are now created more often and are stored for a longer period.

What is the expected result?

Two types of backups:

  • daily, done once a day, with 7 day retention
  • weekly, done twice a week, with 2 week retention

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@NikolayDemchuk
added weekly job
b9991f4 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk NikolayDemchuk changed the title added weekly job [linstor] Improvement of LINSTOR database backup management Oct 1, 2024
@NikolayDemchuk
added some tasks
53635bc 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
changed retention for daily backups
eb90b55 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
trying fixing labels
8d34d61 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
c7fb2f7 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
6e96672 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
testing sorting
cc1c249 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
9c4eb92 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
3097ac4 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
1dfcb8e 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
a bit of cleanup
1b3f8f3 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
whoops
85c4cf9 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fixing retention count
72b6a9f 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
3a62af3 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fixes
8ef80fb 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
6ce87d7 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
tryout
e9bcc64 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
1da08e8 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
changed timeline for testing
3249625 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
d3617d4 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
bump
34b0a21 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
tested backups, removed mistakes from docs
ecdd667 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk NikolayDemchuk self-assigned this Nov 12, 2024
@NikolayDemchuk NikolayDemchuk added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 12, 2024
@NikolayDemchuk NikolayDemchuk marked this pull request as ready for review November 12, 2024 15:49
AleksZimin
AleksZimin reviewed Nov 13, 2024
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
AleksZimin
AleksZimin reviewed Nov 13, 2024
View reviewed changes
docs/FAQ.md Outdated Show resolved Hide resolved
NikolayDemchuk and others added 2 commits November 13, 2024 17:49
@NikolayDemchuk @AleksZimin
Apply suggestions from code review
61f67d6 
Co-authored-by: Aleksandr Zimin <[email protected]>
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fixed doc
d07c2d2 
Signed-off-by: Nikolay Demchuk <[email protected]>
duckhawk
duckhawk previously approved these changes Nov 14, 2024
View reviewed changes
@NikolayDemchuk
fixes
edb9a6d 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
label fix
c0e1820 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
0e0f7e6 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
9603af0 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
7b195a5 
Signed-off-by: Nikolay Demchuk <[email protected]>
@NikolayDemchuk
fix
739312d 
Signed-off-by: Nikolay Demchuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckhawk duckhawk duckhawk left review comments

@AleksZimin AleksZimin Awaiting requested review from AleksZimin

At least 1 approving review is required to merge this pull request.

Assignees

@NikolayDemchuk NikolayDemchuk

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NikolayDemchuk @duckhawk @AleksZimin