fix(cvi,vi): unlock pending vi/cvi from vd ref #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
requested changes
Oct 8, 2024
images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref_vd.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/datasource_ready.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cvi/internal/source/errors.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/attachee.go
Outdated
Show resolved
Hide resolved
Isteb4k
requested changes
Oct 8, 2024
images/virtualization-artifact/pkg/controller/vi/internal/source/object_ref_vd.go
Outdated
Show resolved
Hide resolved
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
2 times, most recently
from
45552d1
to
8e5b4f1
Compare
LopatinDmitr
changed the title
Isteb4k
requested changes
Oct 15, 2024
images/virtualization-artifact/pkg/controller/vd/internal/attachee.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/attachee.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/attachee.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/vd_reconciler.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vi/internal/source/object_ref_vd.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/block_device.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/block_device.go
Show resolved
Hide resolved
Isteb4k
requested changes
Oct 15, 2024
images/virtualization-artifact/pkg/controller/vd/internal/inuse.go
Outdated
Show resolved
Hide resolved
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
from
523f4a4
to
f8134b5
Compare
LopatinDmitr
requested review from
Isteb4k and
diafour
and removed request for
Isteb4k
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
from
70fd271
to
0f11fd4
Compare
diafour
reviewed
Oct 28, 2024
images/virtualization-artifact/pkg/controller/vi/internal/source/errors.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Oct 28, 2024
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
8 times, most recently
from
d37bad7
to
7b7bcd5
Compare
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
from
7b7bcd5
to
11bbb7f
Compare
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
9 times, most recently
from
929fc17
to
1818962
Compare
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
6 times, most recently
from
f5f5d24
to
2c03739
Compare
Isteb4k
previously approved these changes
Nov 22, 2024
images/virtualization-artifact/pkg/controller/cvi/internal/source/object_ref_vd.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vd/internal/inuse.go
Outdated
Show resolved
Hide resolved
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
from
2c03739
to
5bc2012
Compare
Signed-off-by: dmitry.lopatin <[email protected]>
Signed-off-by: dmitry.lopatin <[email protected]>
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
5 times, most recently
from
c4e8c52
to
8d2b638
Compare
Signed-off-by: dmitry.lopatin <[email protected]>
LopatinDmitr
force-pushed
the
fix/vi/unlock-pending-vi-from-vd-ref
branch
from
8d2b638
to
8b0c8b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add conditon 'InUse" for VirtualDisk. This condition indicate:
Add condition 'BlockDeviceAllowed' for VirtualMachine. This condition indicate state VirtualDisk (may be attached or no)
Why do we need it, and what problem does it solve?
Fix problem with lock VirtualImage and ClusterVirtual image in phase 'Pending' after stopping or deleting VirtualMachine, when used needed VirtualDisk in them.
What is the expected result?
Checklist