test(api): add resource deletion step in e2e test cases #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardcoretime
force-pushed
the
test/api/resource-deletion-step-in-e2e-tests
branch
2 times, most recently
from
a3ada25
to
bde4c17
Compare
yaroslavborbat
requested changes
Nov 20, 2024
added 2 commits
November 26, 2024 01:59
- exclude namespace in resource deletion step; - refactor `apply` and `delete` kubectl commands; - handle errors in clean up phase; - add resource deletion step in each test case. Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
test/api/resource-deletion-step-in-e2e-tests
branch
from
3968af5
to
e45b43c
Compare
yaroslavborbat
approved these changes
Nov 26, 2024
hardcoretime
deleted the
test/api/resource-deletion-step-in-e2e-tests
branch
nevermarine
pushed a commit
that referenced
this pull request
Dec 3, 2024
- exclude namespace in resource deletion step; - refactor `apply` and `delete` kubectl commands; - handle errors in clean up phase; - add resource deletion step in each test case. Signed-off-by: Roman Sysoev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
applyanddeletekubectl commands;Description
When test case is completed it's resources should be deleted.
Why do we need it, and what problem does it solve?
To catch errors when virtualization resources cannot be deleted correctly.
What is the expected result?
All resources in E2E tests should be deleted correctly in each test case.
Checklist