Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vd): block resizing VirtualDisk if storage class not ready #526

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

eofff
Copy link
Contributor

@eofff eofff commented Nov 15, 2024

Description

Do not allow resizing operation of VirtualDisk if its StorageClass is not ready.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@eofff eofff marked this pull request as ready for review November 15, 2024 13:57
Copy link
Member

@yaroslavborbat yaroslavborbat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct me if I'm wrong. The condition StorageClassReady means that the storage class exists. And we can't increase the size, but why? What problem does this PR solve?

yaroslavborbat
yaroslavborbat previously approved these changes Nov 20, 2024
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff merged commit 0056296 into main Nov 25, 2024
12 checks passed
@eofff eofff deleted the feat/vd/block-expanding-if-sc-not-ready branch November 25, 2024 13:32
nevermarine pushed a commit that referenced this pull request Dec 3, 2024
Do not allow resizing operation of VirtualDisk if its StorageClass is not ready.

---------

Signed-off-by: Valeriy Khorunzhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants