Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): do not update condition transition time if status not changed #544

Merged

Conversation

eofff
Copy link
Contributor

@eofff eofff commented Nov 28, 2024

Description

Do not update condition last transition time if status not changed.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Valeriy Khorunzhin added 5 commits November 28, 2024 16:14
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff force-pushed the fix/api/do-not-update-transition-time-if-status-not-changed branch from 91d9840 to 624b717 Compare November 28, 2024 13:14
Valeriy Khorunzhin and others added 2 commits November 28, 2024 18:45
@eofff eofff merged commit 668201a into main Nov 28, 2024
12 checks passed
@eofff eofff deleted the fix/api/do-not-update-transition-time-if-status-not-changed branch November 28, 2024 17:44
nevermarine pushed a commit that referenced this pull request Dec 3, 2024
…ed (#544)

Do not update condition last transition time if status not changed.

---------

Signed-off-by: Valeriy Khorunzhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants