Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/huge renaming api and crds #73

Merged
merged 2 commits into from
May 2, 2024

Conversation

diafour
Copy link
Member

@diafour diafour commented Apr 26, 2024

Description

Merge renaming PRs for testing before merging into main

Why do we need it, and what problem does it solve?

Test renamings in dev clusters

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@alexey-igrychev alexey-igrychev force-pushed the feat/huge_renaming_api_and_crds branch from b705372 to 05106a3 Compare May 2, 2024 12:28
@universal-itengineer universal-itengineer added the validation/skip/doc_changes Skip doc changes validation label May 2, 2024
@alexey-igrychev alexey-igrychev force-pushed the feat/huge_renaming_api_and_crds branch from 05106a3 to f95502e Compare May 2, 2024 12:31
- Resource Management:
  - Rename resources to avoid naming clashes.

- CDI Changes:
  - Add 'DVPInternal' prefix to enhance naming clarity.
  - Implement fixes and patches for stability improvements.
  - Introduce non-buffered writer for object watch streams to prevent rewrite.
  - Patches for kubevirt-operator:
    - Patch port in kubevirt webhooks, remove 'WEBHOOK_PROXY=no', add rules covering all known webhook paths.

- Kubevirt Adjustments:
  - VM controller enhancements:
    - Add subscription to detect VMI phase changes.
    - Force 'application/json' in vm-controller for consistent data handling.
    - Simplify ownerReferences renaming to reduce complexity.
  - Virtualization-controller adjustments:
    - Fix proxy settings in deployment.
    - Prioritize proxy container, add 'default-container' annotations to streamline operations.
    - Address goroutines deadlock and potential DATA RACEs in kube proxy.
    - Remove debugging and development-time code for production readiness.
  - Minor:
    - Fix renamed field in VM status.
    - Add certmanager to automatically reload certificates from updated Secrets.
    - Introduce Cyrillic linter to support non-Latin scripts.
    - Change contentType from Error to Warning to reduce log severity.

- Template Enhancements:
  - Rewrite templates to unify configuration settings:
    - Use 'KUBECONFIG' environment variable across all CDI and Kubevirt controllers.
    - Consolidate configurations into a single template for no-webhook-proxy setup.
  - Fix template issues to ensure stability and correctness.

Signed-off-by: Aleksei Igrychev <[email protected]>
Signed-off-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
@universal-itengineer universal-itengineer merged commit 270bf58 into main May 2, 2024
8 checks passed
@diafour diafour deleted the feat/huge_renaming_api_and_crds branch October 16, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation/skip/doc_changes Skip doc changes validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants