feat(presets): include profile in preset owner field #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should probably adjust the corresponding api.ts type to change owner from a number to a User or whatever in this PR, to keep things in-sync |
Oh yeah nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scratch api, we get the full profile with username and user's id in owner field. However in preset we were only getting the id.
This will allow us to improve the Preset card, introduced by #1232 with the user icon.
{ "id": 2, "name": "random", "platform": "dummy", "compiler": "dummy", "assembler_flags": "-dummy-asm", "compiler_flags": "-dummy-compiler", "diff_flags": {}, "decompiler_flags": "-decompiler", "libraries": [], "num_scratches": 0, "owner": 2 }{ "id": 2, "name": "random", "platform": "dummy", "compiler": "dummy", "assembler_flags": "-dummy-asm", "compiler_flags": "-dummy-compiler", "diff_flags": {}, "decompiler_flags": "-decompiler", "libraries": [], "num_scratches": 0, "owner": { "is_anonymous": false, "id": 2, "is_online": true, "is_admin": false, "username": "axel7083", "github_id": 42176370 } }