Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PS2 compiler ee-gcc29-991111b/r4 #1289

Closed
wants to merge 5 commits into from

Conversation

TheOnlyZac
Copy link

This is the compiler for Sly Cooper on PS2.

@TheOnlyZac TheOnlyZac marked this pull request as ready for review July 6, 2024 03:58
@TheOnlyZac TheOnlyZac requested a review from bates64 as a code owner July 6, 2024 03:58
@TheOnlyZac
Copy link
Author

Might need to rerun the checks since my PR on the compilers repo was merged.

@ethteck
Copy link
Member

ethteck commented Jul 7, 2024

@TheOnlyZac this failed https://github.com/decompme/decomp.me/actions/runs/9727725876/job/27109038662?pr=1289

Are you sure you named the output file correctly? I saw in the PR, the archive name doesn't match the compiler ID. it doesn't include the b4 part.. https://github.com/decompme/compilers/pull/15/files#diff-8377b3e3740a3fcd9f682e5fb55425f2fdbece1791854b9e5013e7f1a5e60e7eR224 not sure if that's the issue, but just saw it

@TheOnlyZac
Copy link
Author

Haven't had a chance to look at this but I will soon.

EE_GCC29_991111B_R4 = GCCPS2Compiler(
id="ee-gcc2.9-991111b-r4",
platform=PS2,
cc='${COMPILER_DIR}/bin/ee-gcc -c $COMPILER_FLAGS "$INPUT" -o "$OUTPUT"',
Copy link
Collaborator

@mkst mkst Jul 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a Windows executable ee-gcc.exe, so would need to be invoked with wine or wibo.

$file ee-gcc.exe
ee-gcc.exe: PE32 executable (console) Intel 80386, for MS Windows

I got a little further with this...

EE_GCC29_991111B_R4 = GCCPS2Compiler(
    id="ee-gcc2.9-991111b-r4",
    platform=PS2,
    cc='${WINE} ${COMPILER_DIR}/bin/ee-gcc.exe -c -B "${COMPILER_DIR}"/lib/gcc-lib/ee/2.9-ee-991111/ $COMPILER_FLAGS "$INPUT" -o "$OUTPUT"',
)

... but it doesnt like the #line directives in the code.c:

Reading specs from /backend/compilers/ps2/ee-gcc2.9-991111b-r4/lib/gcc-lib/ee/2.9-ee-991111/specs
gcc version 2.9-ee-991111b/r4
 /backend/compilers/ps2/ee-gcc2.9-991111b-r4/lib/gcc-lib/ee/2.9-ee-991111/cpp.exe -lang-c -v -I Z:\backend\compilers\ps2\ee-gcc2.9-991111b-r4\bin\..\lib/gcc-lib/ee\2.9-ee-991111\ -isystem /backend/compilers/ps2/ee-gcc2.9-991111b-r4/lib/gcc-lib/ee/2.9-ee-991111/include -undef -D__GNUC__=2 -D__GNUC_MINOR__=9 -Dmips -DMIPSEL -DR5900 -D_mips -D_MIPSEL -D_R5900 -D__mips__ -D__MIPSEL__ -D__R5900__ -D___mips__ -D_MIPSEL -D_R5900 -D__mips -D__MIPSEL -D__R5900 -D___mips -D__LANGUAGE_C -D_LANGUAGE_C -DLANGUAGE_C -D__SIZE_TYPE__=unsigned -D__PTRDIFF_TYPE__=int -D__LONG_MAX__=9223372036854775807L -U__mips -D__mips=3 -D__mips64 -D__mips_eabi -D__mips_single_float /tmp/code.c /tmp\ccGaaaaa.i
GNU CPP version 2.9-ee-991111b [AL 1.1, MM 40] BSD Mips
#include "..." search starts here:
End of search list.
 /backend/compilers/ps2/ee-gcc2.9-991111b-r4/lib/gcc-lib/ee/2.9-ee-991111/cc1.exe /tmp\ccGaaaaa.i -quiet -dumpbase code.c -version -o /tmp\cccbaaaa.s
GNU C version 2.9-ee-991111b/r4 (ee) compiled by CC.
/tmp/code.c:1: invalid #-line
/tmp/code.c:5: invalid #-line

code.c:

#line 1 "ctx.c"

#line 1 "src.c"
void func(void) {
    //
}

@mkst
Copy link
Collaborator

mkst commented Jul 22, 2024

Gonna close this PR as it's gone stale. Feel free to re-open once you have the compiler working.

@mkst mkst closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants