api/v2: Duplicate merkle branch definition #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
force-pushed
the
v2_merklebranch
branch
from
7dacb45 to
5e08d81
Compare
|
Also note that while this is a Go API breaking change, the api/v2 submodule has never been tagged. |
davecgh
approved these changes
Feb 14, 2025
This removes the dependency on the main module's merkle package. The JSON marshaling of the merkle branch is disgusting but this would need to be cleaned up in a v3 API if anyone attempts this. Part of a larger change to make actually make the api/v2 submodule actually go-gettable. It is completely busted at the moment, due to importing the main module's merkle package without a require on the main module.
jrick
force-pushed
the
v2_merklebranch
branch
from
d831feb to
96b577f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the dependency on the main module's merkle package.
The JSON marshaling of the merkle branch is disgusting but this would need to be cleaned up in a v3 API if anyone attempts this.
Part of a larger change to make actually make the api/v2 submodule actually go-gettable. It is completely busted at the moment, due to importing the main module's merkle package without a require on the main module.